dengliming opened a new issue, #605:
URL: https://github.com/apache/shenyu-dashboard/issues/605

   ## Description
   `pluginOnClick` dispatches 
`routerRedux.push("plug/${plugin.role}/${plugin.name}")` (template literal) 
without a leading slash. The app uses `createHashHistory` from `history@5`, 
which does not resolve relative pathnames (it warns "Relative pathnames are not 
supported in hash history.push"). The resulting location pathname is 
`plug/sign/sign`, which never matches the `/plug/:index/:id` route. Every other 
navigation in the repo uses an absolute `/plug/...` (e.g. 
`src/utils/AuthRoute.js:145`).
   
   ## Location
   (Lines refer to `master @ 83969a5`.)
   - `src/routes/Home/index.js:89-92`
   - Route definition: `src/common/router.js` (`/plug/:index/:id`)
   
   ## Impact
   Clicking any plugin tag on the Home page shows the NotFound page with URL 
`#plug/...` instead of opening the plugin.
   
   ## Suggested fix
   Prefix the path with `/`: 
`routerRedux.push("/plug/${plugin.role}/${plugin.name}")`.
   
   ## Related existing
   None
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to