Aias00 commented on PR #7026: URL: https://github.com/apache/shenyu/pull/7026#issuecomment-5808319187
Re-checking the failing `it / build (shenyu-integrated-test-sdk-http)` job attributed to this PR. On the current head, **every** integration-test job in the run is failing, not just `sdk-http`: ``` build (shenyu-integrated-test-sdk-http) fail build (shenyu-integrated-test-apache-dubbo) fail build (shenyu-integrated-test-combination) fail build (shenyu-integrated-test-grpc) fail build (shenyu-integrated-test-http) fail build (shenyu-integrated-test-https) fail build (shenyu-integrated-test-rewrite) fail build (shenyu-integrated-test-sdk-apache-dubbo) fail build (shenyu-integrated-test-spring-cloud) fail build (shenyu-integrated-test-websocket) fail ``` while the unit-test matrix passes: ``` build (17, ubuntu-latest) pass build (21, ubuntu-latest) pass ``` A single PR's change breaking all ten integration suites at once, while every unit test passes, is not a plausible failure mode — this pattern points at the shared integration-test environment (image build / compose startup / network) rather than at this diff. For reference, `master` has been showing the same class of intermittent red on `ci` (`Could not find artifact org.apache.shenyu:*:2.7.2-SNAPSHOT in apache.snapshots`), which is infrastructure rather than code. That said, I don't want to hand-wave: if the sdk-http failure has a distinct root cause, the decisive evidence would be a log line from that job pointing into this PR's code path (a validation error raised by the new `@Valid` constraints during registration). If someone has that log excerpt, please share it and I'll re-evaluate immediately. Absent that, I'm keeping my approval — the validation change itself is sound and covered by unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
