Aias00 commented on code in PR #7160:
URL: https://github.com/apache/shenyu/pull/7160#discussion_r4079957447
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/listener/http/HttpLongPollingDataChangedListener.java:
##########
@@ -258,12 +260,13 @@ private boolean checkCacheDelayAndUpdate(final
ConfigDataCache serverCache, fina
if (latest != serverCache) {
return !StringUtils.equals(clientMd5, latest.getMd5());
}
Review Comment:
🟢 Verified this resolves the earlier concern without an explicit
`sendResponse` guard: `clientsMap` is keyed by `namespaceId` (one queue per
client-namespace) and `doRun` `drainTo`s the queue before `sendResponse`, so
the same `asyncContext` is completed at most once per cycle. The per-namespace
`refreshLock` is the right, sufficient fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
