BobSong-dev opened a new pull request, #7174:
URL: https://github.com/apache/shenyu/pull/7174

   Fixes #6593
   
   ## Background
   
   The LRU and Window TinyLFU eviction tests wrapped their complete test bodies 
in `catch (Throwable)`. Because `AssertionError` is a `Throwable`, failed 
assertions and unexpected test errors were silently ignored, allowing the tests 
to pass without verifying eviction behavior.
   
   ## Changes
   
   - Remove the blanket `try`/`catch (Throwable)` from 
`MemorySafeLRUMapTest#testLru`.
   - Remove the blanket `try`/`catch (Throwable)` from 
`MemorySafeWindowTinyLFUMapTest#testWindowTinyLFU`.
   - Preserve the existing capacity and eviction assertions so failures are 
reported by JUnit.
   
   ## Verification
   
   - `MemorySafeLRUMapTest` and `MemorySafeWindowTinyLFUMapTest`: 5 tests 
passed.
   - Checkstyle: 0 violations.
   - `git diff --check`: passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to