Aias00 commented on code in PR #7140:
URL: https://github.com/apache/shenyu/pull/7140#discussion_r4071921949
##########
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-apache-dubbo-service/k8s/shenyu-zookeeper.yml:
##########
@@ -68,7 +68,7 @@ metadata:
app: shenyu-zk
all: shenyu-examples-dubbo
spec:
- type: NodePort
+ type: ClusterIP
Review Comment:
Nit (non-blocking): this change is unrelated to #6775.
`NodePort` → `ClusterIP` for the ZooKeeper service is arguably more correct
(ZK is only consumed in-cluster by the dubbo example pods, so exposing a
NodePort is unnecessary surface), and the k8s ingress CI job passed with it.
But bundling infra/example changes into a bug-fix PR makes backporting and
bisecting harder. Please consider moving this (and the `set -euo pipefail` +
`resolve-ci-modules.sh` edits) into a separate PR next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
