HY-love-sleep commented on issue #7154:
URL: https://github.com/apache/shenyu/issues/7154#issuecomment-5770297600

   Closing this: both parts landed.
   
   - #7153 added the plugin itself (the automaton, the redis dictionary, the 
rule handle).
   - #7155 registered it in the admin: the `plugin`, `plugin_handle`, 
`resource`, `permission`,
     `shenyu_dict` and `namespace_plugin_rel` rows for mysql, ob, pg, og, 
oracle and the h2 script the
     admin uses, the matching `2.7.1-upgrade-2.7.2-*` scripts with their entry 
in the upgrade guide, the
     rule level `words` field so a small list can be configured straight from 
the console form, and the
     rule level `maxBodySize` bound (checked against the declared 
`Content-Length` before the body is
     buffered and once more after it has been read; an oversized request is 
passed through unscanned, or
     rejected when the rule is `failClosed`).
   
   The plugin is therefore reachable and configurable from the console, which 
is what this issue was
   about.
   
   **Not included, on purpose**: uploading a word list file from the console. 
It needs a redis client
   inside `shenyu-admin` (the admin has none today), an upload endpoint with 
its own size limit, encoding
   and audit rules, and a component in the separate `shenyu-dashboard` 
repository. Redis remains the way
   to feed a large dictionary and the module README documents it. If the upload 
is wanted, it deserves
   its own issue rather than reopening this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to