Copilot commented on code in PR #7099:
URL: https://github.com/apache/shenyu/pull/7099#discussion_r4032825446
##########
shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-tars/src/test/java/org/apache/shenyu/plugin/tars/cache/ApplicationConfigCacheTest.java:
##########
@@ -121,6 +124,30 @@ public void testConcurrentInitPrx() {
});
}
+ @Test
+ public void testInitPrxWaitsForInitializationLock() throws Exception {
Review Comment:
This regression test is currently never executed: this module configures
Maven Surefire with `<skip>true</skip>` in `shenyu-plugin-tars/pom.xml:65-73`,
and `-DskipTests=false` does not override that setting. The PR description also
notes that the module skip was only temporarily disabled, so the busy-spin
regression can return unnoticed in normal CI. Commit a POM change that enables
this test (or an appropriate test profile) as part of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
