Copilot commented on code in PR #7081:
URL: https://github.com/apache/shenyu/pull/7081#discussion_r4032821212
##########
shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/AppAuthServiceImpl.java:
##########
@@ -151,14 +151,19 @@ public ShenyuAdminResult applyUpdate(final AuthApplyDTO
authApplyDTO) {
if (Objects.isNull(appAuthDO)) {
return
ShenyuAdminResult.error(ShenyuResultMessage.APPKEY_NOT_EXIST_ERROR);
}
+ appAuthDO.setUserId(authApplyDTO.getUserId());
+ appAuthDO.setPhone(authApplyDTO.getPhone());
+ appAuthDO.setExtInfo(authApplyDTO.getExtInfo());
+ appAuthDO.setOpen(authApplyDTO.getOpen());
Review Comment:
`open` is optional in `AuthApplyDTO`, so a valid contact-only update can
supply `null`. Mutating the loaded entity to `null` while `updateSelective`
skips the database column makes the published event carry `open=null` even when
the persisted value is `true`; `ComposableSignService` treats that as path
authorization being off. Preserve the existing entity value when `open` is
omitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
