juicewcode opened a new pull request, #6964:
URL: https://github.com/apache/shenyu/pull/6964
Fixes #6866
## Summary
EmailAlertNotifyStrategy.buildAlertHtmlTemplate null-guarded the wrong
variable: Objects.isNull(alert) is dead code (alert already dereferenced). When
dateCreated is null, alertTime stayed null and SimpleDateFormat.format() threw
NPE, crashing the email notify path. Now guards alertTime and falls back to new
Date(), matching AbstractAlertNotifyHandler.
Added EmailAlertNotifyStrategyTest:
- null dateCreated → no AlertNoticeException, falls back to current time,
email sent
- fixed dateCreated → formatted exactly, email sent
<!-- Describe your PR here; e.g. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through
the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution
guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your
changes.
- [x] Your local test passed `./mvnw clean install
-Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
