BobSong-dev opened a new pull request, #6944: URL: https://github.com/apache/shenyu/pull/6944
Fixes #6769 ## Background `RabbitmqLogCollectClient.close0()` previously closed the channel and connection in the same `try` block. If `channel.close()` threw an `IOException`, control jumped to the `catch` block and `connection.close()` was skipped. This could leave the RabbitMQ connection open. ## Changes - Handle channel and connection closure separately; - Attempt to close the connection in `finally` even when channel closure fails; - Log channel and connection close failures separately; - Add a regression test to verify that the connection is still closed when channel closure fails. ## Verification - `RabbitmqLogCollectClientTest`: 2 tests run, 0 failures, 0 errors; - Full tests for the RabbitMQ module and its dependencies passed; - RabbitMQ module: 17 tests run, 0 failures, 0 errors; - `BUILD SUCCESS`; - `git diff --check` passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
