wy471x opened a new pull request, #6938: URL: https://github.com/apache/shenyu/pull/6938
<!-- Describe your PR here; e.g. Fixes #issueNo --> <!-- Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request. --> Make sure that: - [X] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide). - [X] You submit test cases (unit or integration tests) that back your changes. - [X] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`. ## Summary ### Changes: 1. Connect.allowedProtocolVersion (Connect.java:90) — previously only accepted MQTT 3.1 (protocol level 3), rejecting virtually all modern clients. Now accepts MQTT 3.1, 3.1.1 (level 4), and 5.0 (level 5). Verified no decoder/encoder changes are needed: Netty 4.1.111's MqttDecoder/MqttEncoder handle 3.1.1/5.0 CONNECT and CONNACK per-channel automatically. 2. Missing return after rejection (MQTT-01, #6637) — after sending CONNECTION_REFUSED_UNACCEPTABLE_PROTOCOL_VERSION, execution fell through to authentication and could send a conflicting CONNECTION_ACCEPTED. Added return. ### Test Cases: 1. New ConnectTest.java — 4 tests: each supported version gets CONNECTION_ACCEPTED and registers the channel; unsupported version gets exactly one rejection CONNACK and no channel registration. close [#6839](https://github.com/apache/shenyu/issues/6839) close [#6637](https://github.com/apache/shenyu/issues/6637) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
