yykaue opened a new pull request, #6934:
URL: https://github.com/apache/shenyu/pull/6934

   ## Description
   
   Fixes #6705.
   
   `InstanceCheckService.close()` previously called `executor.shutdown()` 
unconditionally. When `setup()` was not invoked, the executor remained `null`, 
causing an NPE during application shutdown.
   
   This PR:
   
   - Adds a null check before shutting down the executor.
   - Preserves the existing database synchronization and instance cleanup 
behavior.
   - Adds a regression test for calling `close()` without invoking `setup()`.
   
   ## Tests
   
   - `InstanceCheckServiceTest`: 8 tests passed.
   - `shenyu-admin`: 1,440 tests passed, 0 failures, 1 skipped.
   - Checkstyle passed with 0 violations.
   
   @Aias00 Please review this PR when you have time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to