Aias00 commented on PR #6912:
URL: https://github.com/apache/shenyu/pull/6912#issuecomment-5288964955
Optional, non-blocking suggestions
Consider extracting "rpcExt" into a shared constant (e.g. in
org.apache.shenyu.common.constant.Constants) used by both DubboServiceProcessor
and the two registrars, so a writer/reader key mismatch like this can't
silently reappear.
Tiny nit: the @SuppressWarnings("unchecked") on the new invokeGetExt helper
is unnecessary (there is no unchecked cast) — it appears to be copied from
invokeGetDocument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
