wy471x opened a new pull request, #6896:
URL: https://github.com/apache/shenyu/pull/6896

   <!-- Describe your PR here; e.g. Fixes #issueNo -->
   
   <!--
   Thank you for proposing a pull request. This template will guide you through 
the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [X] You have read the [contribution 
guidelines](https://shenyu.apache.org/community/contributor-guide).
   - [X] You submit test cases (unit or integration tests) that back your 
changes.
   - [X] Your local test passed `./mvnw clean install 
-Dmaven.javadoc.skip=true`.
   
   ## Summary
   ### Bug Fix (3 files)                                                        
                                                                                
                          
      
     DubboIngressParser.java, GrpcParser.java, SofaParser.java — in each 
parseIngressRule method, added null-safety guards before iterating over labels: 
                               
                                                               
     1. Null/empty labels check — if labels is null or empty, skip the label 
iteration with continue instead of throwing NullPointerException.               
                           
     2. Missing service check — before calling .getMetadata().getAnnotations(), 
check if serviceLister.namespace(namespace).get(...) returned null (service not 
yet in cache). Log a
     warning and continue, allowing a later reconcile to pick it up once the 
service cache is populated.                                                     
                           
                                                               
   ### Unit Tests (3 new files, 9 tests)                                        
                                                                                
                          
                                                               
     - DubboIngressParserTest.java — 3 tests                                    
                                                                                
                        
     - GrpcParserTest.java — 3 tests                           
     - SofaParserTest.java — 3 tests   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to