Aias00 opened a new issue, #6848:
URL: https://github.com/apache/shenyu/issues/6848

   ## Description
   The SUBACK grant list is built by hard-coding `MqttQoS.AT_MOST_ONCE.value()` 
for every topic, never reading `topicSub.qualityOfService()`.
   
   ## Location
   - 
`shenyu-protocol/shenyu-protocol-mqtt/src/main/java/org/apache/shenyu/protocol/mqtt/Subscribe.java:90-94`
 (line 93 hard-codes `AT_MOST_ONCE.value()`)
   
   ## Impact
   A client subscribing at QoS 1 or 2 is told it was granted QoS 0 and (see 
H-27) will only ever receive QoS 0 delivery. Violates MQTT-3.8.4/3.9.
   
   ## Suggested fix
   `qos.add(topicSub.qualityOfService().value())` (after the FAILURE filter).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to