Aias00 opened a new issue, #6709: URL: https://github.com/apache/shenyu/issues/6709
- severity: Medium - files: `shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/ScaleRuleServiceImpl.java:124-131` - description: `update(...)` calls `scaleRuleMapper.updateByPrimaryKey(after)` (full column update). Contrast with `create` which uses `insertSelective` and the convention elsewhere (`AlertReceiverServiceImpl`/`DetailServiceImpl`/`FieldServiceImpl` use `updateByPrimaryKeySelective`). Any field the DTO does not populate (e.g. `sort`, `status`, `minimum`, `maximum`) is written as NULL. Also rebuilds the DO a second time on line 128 (same double-build pattern as N11). - impact: Partial PUT payloads silently wipe scale-rule thresholds/state. - suggested_fix: Use `updateByPrimaryKeySelective(after)` and reuse `after` instead of rebuilding. - confidence: Medium - related_existing: none. --- _Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/06-medium-tiers.md`](docs/scan2-2026-08-02/06-medium-tiers.md)._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
