Aias00 opened a new issue, #6665: URL: https://github.com/apache/shenyu/issues/6665
- Severity: High - Location: `shenyu-client/shenyu-client-websocket/shenyu-client-spring-websocket/src/main/java/org/apache/shenyu/client/spring/websocket/init/SpringWebSocketClientEventListener.java:229` - Description: `buildMetaDataDTO` builds the `MetaDataRegisterDTO` with `.enabled(true)` literally. The annotation declares `boolean enabled() default true;` (`ShenyuSpringWebSocketClient.java:68`) and is meant to allow disabling a route. Every other client honors the field — SOFA does `.enabled(shenyuSofaClient.enabled())` (`SofaServiceEventListener.java:170`), Tars `.enabled(shenyuTarsClient.enabled())` (`TarsServiceBeanEventListener.java:191`), MCP `metaDataRegisterDTO.setEnabled(shenyuMcpTool.getEnable())` (`McpServiceEventListener.java:370`). Only WebSocket ignores it. - Impact: `@ShenyuSpringWebSocketClient(enabled = false)` to take a websocket endpoint offline still registers the metadata as enabled; the route stays live — opt-out silently broken (availability/security). - Suggested fix: Replace `.enabled(true)` with `.enabled(webSocketClient.enabled())`. - Confidence: High - Related existing: none --- _Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/00-consolidated-critical-high.md`](docs/scan2-2026-08-02/00-consolidated-critical-high.md)._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
