funky-eyes commented on code in PR #8057:
URL: https://github.com/apache/incubator-seata/pull/8057#discussion_r3144764321
##########
server/src/main/java/org/apache/seata/server/storage/file/lock/FileLocker.java:
##########
@@ -95,8 +95,6 @@ public boolean acquireLock(List<RowLock> rowLocks, boolean
autoCommit, boolean s
Set<String> keysInHolder = CollectionUtils.computeIfAbsent(
bucketHolder, bucketLockMap, key ->
ConcurrentHashMap.newKeySet());
keysInHolder.add(pk);
- } else if (previousLockBranchSession.getTransactionId() ==
transactionId) {
Review Comment:
Removing this code would break the logic, right?
##########
saga/seata-saga-engine/src/main/java/org/apache/seata/saga/engine/strategy/impl/DefaultStatusDecisionStrategy.java:
##########
@@ -117,8 +117,6 @@ public static void
setMachineStatusBasedOnStateListAndException(
hasSuccessUpdateService = true;
}
}
- } else if
(ExecutionStatus.SK.equals(stateInstance.getStatus())) {
Review Comment:
Removing this code would break the logic, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
