xuxiaowei-com-cn commented on PR #8057: URL: https://github.com/apache/incubator-seata/pull/8057#issuecomment-4295250480
> > > I would still prefer to keep PMD or find an alternative to P3C. Otherwise, it will be difficult to enforce standards for variable naming conventions, code style, enum comments, and code annotations. At the very least, it currently provides some level of constraint on the JDK 8 pipeline, helping to maintain standardization. > > > > > > # 中文 > > > > 1. 我看到项目中引入了 `org.apache.maven.plugins:maven-checkstyle-plugin`，并且被禁用了。 > > 2. `org.apache.maven.plugins:maven-checkstyle-plugin` 也能实现你说的效果吧？ > > 3. 这个项目已经捐献给 Apache 基金会，使用 `org.apache.maven.plugins:maven-checkstyle-plugin` 也是理所因该的吧？ > > > > # English > > > > 1. I noticed that the project introduced `org.apache.maven.plugins:maven-checkstyle-plugin`, and it is disabled. > > 2. `org.apache.maven.plugins:maven-checkstyle-plugin` can also achieve the effect you mentioned, right? > > 3. This project has been donated to the Apache Foundation, so it is only natural to use `org.apache.maven.plugins:maven-checkstyle-plugin`, right? > > If the maven-checkstyle-plugin can replace the capabilities of PMD, I agree with your suggestion. - 需要研究一下 p3c 的规则与 `org.apache.maven.plugins:maven-checkstyle-plugin` 的规则，并将规则进行转换。 - It is necessary to study the rules of p3c and those of `org.apache.maven.plugins:maven-checkstyle-plugin`, and then convert the rules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
