Sumit6307 commented on code in PR #7981:
URL: https://github.com/apache/incubator-seata/pull/7981#discussion_r3118673138
##########
rm-datasource/src/test/java/org/apache/seata/rm/datasource/DataSourceProxyTest.java:
##########
@@ -237,7 +237,33 @@ public void testCloseRemovesResource() throws Exception {
proxy.close();
+ verify(drm).unregisterResource(proxy);
tmcfStatic.verify(() ->
TableMetaCacheFactory.shutdown(proxy.getResourceId()));
+ verify(drm).unregisterResource(proxy);
Review Comment:
> nit: duplicate `verify(drm).unregisterResource(proxy)` — this line can be
removed.
@WangzJi
Done. Removed the duplicate `verify` line as suggested.
Thanks for pointing that out! Let me know if everything else looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
