funky-eyes commented on code in PR #7981:
URL: https://github.com/apache/incubator-seata/pull/7981#discussion_r2893223218
##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/DataSourceProxy.java:
##########
@@ -294,7 +294,7 @@ public String getUserName() {
}
public void close() throws Exception {
- // TODO: Need to unregister resource from DefaultResourceManager
+ DefaultResourceManager.get().unregisterResource(this);
Review Comment:
This operation must send a resource-unload request to the server; if the
resource is only unloaded locally, the server will be unaware and may still
dispatch phase-two execution tasks to that node. It also needs to be
version-aware: if the client is a newer version than the server, the server
might not support the unload-resource request at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
