LegendPei commented on code in PR #8046:
URL: https://github.com/apache/incubator-seata/pull/8046#discussion_r3079117013
##########
json-common/pom.xml:
##########
@@ -27,38 +27,25 @@
</parent>
<modelVersion>4.0.0</modelVersion>
<artifactId>json-common</artifactId>
- <packaging>jar</packaging>
+ <packaging>pom</packaging>
<name>json-common ${project.version}</name>
- <description>jsonUtil for Seata modules</description>
-
- <dependencies>
- <dependency>
- <groupId>${project.groupId}</groupId>
- <artifactId>seata-common</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>${project.groupId}</groupId>
- <artifactId>seata-core</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>com.alibaba</groupId>
- <artifactId>fastjson</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
- <scope>provided</scope>
- </dependency>
- <dependency>
- <groupId>com.google.code.gson</groupId>
- <artifactId>gson</artifactId>
- <scope>provided</scope>
- </dependency>
- </dependencies>
-
-
-
-</project>
\ No newline at end of file
+ <description>json-common top parent for Seata built with
Maven</description>
+
Review Comment:
This version hasn't been released yet, so we can probably disregard the
compatibility of this particular aspect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
