Copilot commented on code in PR #8046: URL: https://github.com/apache/incubator-seata/pull/8046#discussion_r3070616039
########## json-common/json-common-core/pom.xml: ########## @@ -0,0 +1,67 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <groupId>org.apache.seata</groupId> + <artifactId>json-common</artifactId> + <version>${revision}</version> + </parent> + <modelVersion>4.0.0</modelVersion> + <artifactId>json-common-core</artifactId> + <packaging>jar</packaging> + <name>json-common-core ${project.version}</name> + <description>jsonUtil core for Seata modules</description> + + <dependencies> + <dependency> + <groupId>${project.groupId}</groupId> + <artifactId>seata-common</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>${project.groupId}</groupId> + <artifactId>seata-core</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>com.alibaba</groupId> + <artifactId>fastjson</artifactId> + <scope>provided</scope> + </dependency> + <dependency> + <groupId>com.alibaba.fastjson2</groupId> + <artifactId>fastjson2</artifactId> + <scope>provided</scope> + </dependency> Review Comment: This module reintroduces `com.alibaba:fastjson` (1.x) as a supported serializer (and scripts/config still default to `fastjson`). Given the PR claims to fix #8024 (“Replace Fastjson 1.x with Fastjson 2.x”), this looks like a partial implementation at best. Either update the PR/issue linkage to reflect “add fastjson2 support” (not replacement), or consider deprecating/removing the Fastjson 1.x serializer and switching defaults to `fastjson2` where feasible. ########## json-common/pom.xml: ########## @@ -27,38 +27,25 @@ </parent> <modelVersion>4.0.0</modelVersion> <artifactId>json-common</artifactId> - <packaging>jar</packaging> + <packaging>pom</packaging> <name>json-common ${project.version}</name> - <description>jsonUtil for Seata modules</description> - - <dependencies> - <dependency> - <groupId>${project.groupId}</groupId> - <artifactId>seata-common</artifactId> - <version>${project.version}</version> - </dependency> - <dependency> - <groupId>${project.groupId}</groupId> - <artifactId>seata-core</artifactId> - <version>${project.version}</version> - </dependency> - <dependency> - <groupId>com.alibaba</groupId> - <artifactId>fastjson</artifactId> - <scope>provided</scope> - </dependency> - <dependency> - <groupId>com.fasterxml.jackson.core</groupId> - <artifactId>jackson-databind</artifactId> - <scope>provided</scope> - </dependency> - <dependency> - <groupId>com.google.code.gson</groupId> - <artifactId>gson</artifactId> - <scope>provided</scope> - </dependency> - </dependencies> - - - -</project> \ No newline at end of file + <description>json-common top parent for Seata built with Maven</description> + Review Comment: Changing the `json-common` artifact packaging from `jar` to `pom` is a backwards-incompatible change for any external consumers still depending on `org.apache.seata:json-common` for runtime classes. Consider keeping `json-common` as a jar (possibly as a thin wrapper that depends on `json-common-core`) and introducing a separate parent/aggregator artifact (e.g. `json-common-parent`) for the multi-module build, or otherwise documenting/migrating this breaking change explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
