Re: [PR] bugfix: fail fast for unimplemented registry types in InitRegistry [incubator-seata-go]

Fri, 27 Mar 2026 22:18:08 -0700 


AlexStocks commented on code in PR #1077:
URL: 
https://github.com/apache/incubator-seata-go/pull/1077#discussion_r3004225321


##########
pkg/discovery/init.go:
##########
@@ -35,18 +35,8 @@ func InitRegistry(serviceConfig *ServiceConfig, 
registryConfig *RegistryConfig)
        case ETCD:
                //init etcd registry
                registryService = newEtcdRegistryService(serviceConfig, 
&registryConfig.Etcd3)
-       case NACOS:
-               //TODO: init nacos registry
-       case EUREKA:
-               //TODO: init eureka registry
-       case REDIS:
-               //TODO: init redis registry
-       case ZK:
-               //TODO: init zk registry
-       case CONSUL:
-               //TODO: init consul registry
-       case SOFA:
-               //TODO: init sofa registry
+       case NACOS, EUREKA, REDIS, ZK, CONSUL, SOFA:

Review Comment:
   [P1] 将未实现的注册中心类型改为返回错误，实现快速失败。原代码 TODO 注释静默跳过导致用户无法感知配置错误。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to