VanKhanhAnny opened a new pull request, #1077: URL: https://github.com/apache/incubator-seata-go/pull/1077
<!-- Thanks for sending a pull request! --> <!-- Please make sure you have read and understood the contributing guidelines --> - [x] I have registered the PR [changes](https://github.com/apache/incubator-seata-go/tree/master/changes). **What this PR does**: Make `pkg/discovery.InitRegistry(...)` fail fast for currently recognized but unimplemented registry types (`nacos`, `eureka`, `redis`, `zk`, `consul`, and `sofa`) and add test coverage for those cases **Which issue(s) this PR fixes**: Fixes a discovery initialization bug where unimplemented registry types are accepted by name without returning a clear error <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_* --> Fixes #1076 **Special notes for your reviewer**: This PR is intentionally small and focused on the registry initialization path only. It does not implement new registry adapters and it makes the current support boundary explicit and adds tests for the fail-fast behavior **Does this PR introduce a user-facing change?**: Yes. Configuring an unimplemented registry type now fails fast with a clear error instead of being accepted silently during registry initialization <!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". --> ```release-note Make `InitRegistry` fail fast for currently unimplemented registry types and add tests covering those cases ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
