somiljain2006 opened a new pull request, #8026:
URL: https://github.com/apache/incubator-seata/pull/8026
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [ ] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [ ] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
- Add support for registry.nacos.ip and registry.nacos.port
- Allow overriding the address registered to Nacos independently of the
server listen address
- Prioritize System properties over file configuration, with fallback to
default behavior
- Ensure backward compatibility when no override is configured
### Ⅱ. Does this pull request fix one issue?
Fixes #8016
### Ⅲ. Why don't you add test cases (unit test/integration test)?
- Added comprehensive tests for override and precedence scenarios
### Ⅳ. Describe how to verify it
1. Run unit tests:
./mvnw -pl discovery/seata-discovery-nacos
-Dtest=NacosRegistryServiceImplTest test
2. Start the Nacos server locally
3. Run Seata server from source with JVM overrides:
./mvnw -pl server clean compile exec:java \
-Dexec.mainClass="org.apache.seata.server.ServerApplication" \
-Dregistry.nacos.ip=127.0.0.1 \
-Dregistry.nacos.port=21908
4. Verify registration in Nacos:
curl
http://localhost:8848/nacos/v1/ns/instance/list?serviceName=seata-server
Expected result:
- IP = 127.0.0.1
- Port = 21908
This confirms that System properties override the default registration
address.
### Ⅴ. Special notes for reviews
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
