pjfanning commented on code in PR #1494:
URL: https://github.com/apache/pekko-connectors/pull/1494#discussion_r2935157531
##########
google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/impl/PekkoGrpcSettings.scala:
##########
@@ -43,13 +43,10 @@ import scala.annotation.nowarn
.withFallback(sys.settings.config.getConfig("pekko.grpc.client.\"*\"")))
(config.callCredentials: @nowarn("msg=deprecated")) match {
- case None => settings
- case Some(DeprecatedCredentials(_)) => // Deprecated credentials were
loaded from config so override them
- sys.log.warning(
- "Config path
pekko.connectors.google.cloud.pubsub.grpc.callCredentials is deprecated, use
pekko.connectors.google.credentials")
+ case Some(creds) => settings.withCallCredentials(creds)
+ case None =>
Review Comment:
I guess since this is targeted at 2.0.0 that we can risk breaking the usage
for users who for some unknown reason might need no credentials
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
