hanishi commented on code in PR #1494:
URL: https://github.com/apache/pekko-connectors/pull/1494#discussion_r2925880072
##########
google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/PubSubSettings.scala:
##########
@@ -37,7 +32,8 @@ final class PubSubSettings private (
@deprecated(
"Use org.apache.pekko.stream.connectors.google.GoogleSettings",
"Alpakka 3.0.0") @Deprecated val callCredentials: Option[
- CallCredentials]) {
+ CallCredentials],
+ private[grpc] val useGoogleSettings: Boolean = true) {
Review Comment:
Addressed. The useGoogleSettings parameter has been removed from the
PubSubSettings constructor entirely. Instead of adding a flag, credential
resolution now always delegates to GoogleSettings when callCredentials is None.
The primary constructor signature is unchanged.
However, this won't be pushed until everything is verified with real GCP
environment testing.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
