jrudolph commented on code in PR #981:
URL: https://github.com/apache/pekko-http/pull/981#discussion_r2904178173
##########
http2-tests/src/test/scala/org/apache/pekko/http/impl/engine/http2/RequestParsingSpec.scala:
##########
@@ -477,7 +488,76 @@ class RequestParsingSpec extends PekkoSpecWithMaterializer
with Inside with Insp
// a CONNECT request (Section 8.3). An HTTP request that omits
// mandatory pseudo-header fields is malformed
- // [assume CONNECT not supported]
+ // 8.3. HTTP/2 CONNECT Method
Review Comment:
Do we support `CONNECT` at all? Is that even something that user code could
implement?
Since we make the logic more strict, it could still be ok to fix this here
but we should make sure we don't mask an error that reports that CONNECT is not
supported with a different parsing error now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
