He-Pin commented on code in PR #981:
URL: https://github.com/apache/pekko-http/pull/981#discussion_r2901580793
##########
http-core/src/main/scala/org/apache/pekko/http/impl/engine/http2/RequestParsing.scala:
##########
@@ -182,11 +186,20 @@ private[http2] object RequestParsing {
}
}
- val incomingHeaders = subStream.initialHeaders.keyValuePairs.toIndexedSeq
- if (incomingHeaders.size > serverSettings.parserSettings.maxHeaderCount)
- malformedRequest(
- s"HTTP message contains more than the configured limit of
${serverSettings.parserSettings.maxHeaderCount} headers")
- else rec(incomingHeaders, 0)
+ try {
+ subStream.initialHeaders.headerParseErrorDetails match {
+ case Some(details) =>
+ BadRequest(details, subStream.streamId)
Review Comment:
```suggestion
// header errors already found in decompression
BadRequest(details, subStream.streamId)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
