[ 
https://issues.apache.org/jira/browse/OFBIZ-13228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18028987#comment-18028987
 ] 

ASF subversion and git services commented on OFBIZ-13228:
---------------------------------------------------------

Commit 0668892ea618138f5b458be749c08150a09c15e9 in ofbiz-plugins's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=0668892ea ]

Implemented: Fix all codenarc violation (OFBIZ-13228) (#137) second attempt

After updated codenarc to 3.6.0, we fixed files didn't previously manage by 
codenarc 3.5.0


> Fix all codenarc violation
> --------------------------
>
>                 Key: OFBIZ-13228
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-13228
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS, ALL PLUGINS
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Major
>              Labels: codenarc, groovy, violation
>
> After implementation of codenarc OFBIZ-11167 we let some error due to the 
> huge work to fix them.
> We currently allow 4384 violations (410 lvl2 and 3974  lvl3) on framework and 
> plugins
> To know if we didn't introduce any new violation we need to add all plugins 
> or check the current framework violation to adapt our locale code.
> To simplify the quality development we suggest to set allow violation to 0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to