[
https://issues.apache.org/jira/browse/OFBIZ-13228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949479#comment-17949479
]
ASF subversion and git services commented on OFBIZ-13228:
---------------------------------------------------------
Commit 172516e7632b3aa4ffd278b93f89981122b530aa in ofbiz-framework's branch
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=172516e763 ]
Implemented: Fix all codenarc violation (OFBIZ-13228)
Fix codenarc violation lvl 2 :
* AssignmentInConditional
* LineLength
* PackageName
Fix codenarc violation lvl 3 :
* BlockStartsWithBlankLine
* ConsecutiveBlankLines
* FileEndsWithoutNewline
* ImportFromSamePackage
* JavadocEmptyReturnTag
* JavadocMissingParamDescription
* SpaceAfterComma
* SpaceAfterOpeningBrace
* SpaceAroundMapEntryColon
* SpaceBeforeClosingBrace
* UnnecessaryGString
* UnusedImport
> Fix all codenarc violation
> --------------------------
>
> Key: OFBIZ-13228
> URL: https://issues.apache.org/jira/browse/OFBIZ-13228
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL APPLICATIONS, ALL PLUGINS
> Reporter: Nicolas Malin
> Priority: Major
> Labels: codenarc, groovy, violation
>
> After implementation of codenarc OFBIZ-11167 we let some error due to the
> huge work to fix them.
> We currently allow 4384 violations (410 lvl2 and 3974 lvl3) on framework and
> plugins
> To know if we didn't introduce any new violation we need to add all plugins
> or check the current framework violation to adapt our locale code.
> To simplify the quality development we suggest to set allow violation to 0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
