eirikbakke commented on PR #9327: URL: https://github.com/apache/netbeans/pull/9327#issuecomment-4237169711
@lahodaj Thank you for chiming in! Is the new approach "correct but needs optimization", or are there ways the logic is still broken even after the patch? I pushed an optimization which will share the JavacTaskImpl between symbols for each root during JavaSymbolProvider.computeSymbolNames. This avoids creating a new javac for every symbol. On the other hand I did not try to preserve the cache between multiple instances of computeSymbolNames. Do you prefer a longer-held cache? (I imagine it might not be straightforward to detect when the Go to Symbol dialog is closed, so a longer-held cache would just use SoftReference as you suggest. But scoping the cache to computeSymbolNames only keeps things simple, and also lets us keep at most one javac in memory at any given time.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
