mbien commented on code in PR #9327:
URL: https://github.com/apache/netbeans/pull/9327#discussion_r3068151941
##########
ide/jumpto/src/org/netbeans/modules/jumpto/symbol/ContentProviderImpl.java:
##########
@@ -391,8 +391,6 @@ public void run() {
if (done || resultChanged) {
lastSize = newSize[0];
lastProvCount = newProvCount;
- model.remove(toRemove);
- model.add(toAdd);
Review Comment:
only took a quick glance at it since the sun is shining:
model changes happen in `Models#casData` which posts the task onto EDT.
Since its a queue, those two calls would run before the `invokeLater()` of L408
(original file). If I see this correctly, the modification here is redundant
and might have other side effects - everything should be on EDT already. Should
be easy to verify by adding a few printlns.
edit: unless the problem is that remove+add must happen in an atomic update,
in that case we would have to take a look at other usages too since it will
likely occur in the other 3 impls too - i saw some copied code last time I did
something with those windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
