jtulach commented on code in PR #9302:
URL: https://github.com/apache/netbeans/pull/9302#discussion_r3016719671
##########
.github/workflows/main.yml:
##########
@@ -1575,8 +1575,8 @@ jobs:
- name: debugger.jpda.projectsui
run: ant $OPTS -f java/debugger.jpda.projectsui test
-# - name: debugger.jpda.truffle
-# run: ant $OPTS -f java/debugger.jpda.truffle test
+ - name: debugger.jpda.truffle
Review Comment:
+1, I am really glad to see the tests being run regularly!
##########
java/debugger.jpda/test/unit/src/org/netbeans/api/debugger/jpda/JPDASupport.java:
##########
@@ -209,50 +209,10 @@ public static JPDASupport attach (String[] vmArgs, String
mainClass, String[] ar
return new JPDASupport (jpdaDebugger, pio);
}
- public static JPDASupport attachScript(String launcher, String path)
throws IOException, DebuggerStartException {
Review Comment:
Huge simplification by deleting a lot of code. Good work!
##########
java/debugger.jpda.truffle/nbproject/project.xml:
##########
@@ -266,25 +272,22 @@
<code-name-base>org.netbeans.libs.freemarker</code-name-base>
<recursive/>
</test-dependency>
+ <test-dependency>
+
<code-name-base>org.netbeans.libs.graaljs</code-name-base>
Review Comment:
Graal.js is packaged as NetBeans module, so reusing it is a great idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
