lahodaj opened a new pull request, #9302:
URL: https://github.com/apache/netbeans/pull/9302
It is my understanding failing tests for `java/debugger.jpda.truffle` may
become an impediment to adopt JDK 21. So, this is an attempt to show a possible
direction to fix the `debugger.jpda.truffle` tests. Instead of running the
GraalVM launcher (which no longer exists), run `java` with the appropriate
launcher class.
This patch currently only fixes JS, as that's what we already have/bundle.
Hopefully support for R/Python/Ruby could be added, by downloading the
appropriate libraries (if they exist) and adding the to the runtime classpath.
I didn't try myself, though. Please feel free to enhance the patch.
A good property is that the tests no longer require the GraalVM, but can run
on any supported JDK.
I did not (yet?) do updates to the ` GraalVM ${{ matrix.graal }} Tests`
GitHub Actions job. Should this be moved to GraalVM 21?
Please let me know what you think.
/cc @mbien , @JaroslavTulach
---
**^Add meaningful description above**
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated
otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache
License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and
email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more
information.
If you're a committer, please label the PR before pressing "Create pull
request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly
labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)),
did the right tests run? When did they run?
2. [ ] Is this PR
[squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are
[co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line)
correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration?
Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't
merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery).
([full wiki
article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
