sharanggupta commented on PR #4393:
URL: https://github.com/apache/logging-log4j2/pull/4393#issuecomment-6315428272
One more point, which the review did not raise but which I noticed while
making these changes: the characters that `$` can escape are fixed to `:`, `-`
and `}`, even when a `StrSubstitutor` is created with a different suffix or
value delimiter. For example, with `new StrSubstitutor(map, "${", "]", '$',
":-")`:
* `${undefined:-a$}b]` now gives `a}b`, while `2.x` gives `a$}b`;
* `${undefined:-a$]b]` gives `a$b]`, because `$]` does not escape the
configured suffix.
Configuration files always use the default syntax, so this only affects code
that creates its own `StrSubstitutor`. Should the new escapes apply only with
the default suffix and delimiter, or follow the configured ones? I'm happy to
do either in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
