ramanathan1504 commented on code in PR #4372:
URL: https://github.com/apache/logging-log4j2/pull/4372#discussion_r4329012647
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/OnStartupTriggeringPolicy.java:
##########
@@ -88,6 +88,10 @@ public void initialize(final RollingFileManager manager) {
}
}
+ static boolean isFileOlderThanStartup(final long fileTime, final long
startupTime) {
+ return fileTime < RollingFileManager.alignMillisToSecond(startupTime);
Review Comment:
`initialTime` set after a rollover is not rounded. Rounding both sides keeps
a file created by this JVM from ever looking older.
```suggestion
return RollingFileManager.alignMillisToSecond(fileTime) <
RollingFileManager.alignMillisToSecond(startupTime);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
