ppkarwasz commented on code in PR #3501:
URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2105250155
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/properties/PropertiesConfigurationBuilder.java:
##########
@@ -124,6 +125,12 @@ public PropertiesConfiguration build() {
}
}
+ final Map<String, Properties> monitorResources =
PropertiesUtil.partitionOnCommonPrefixes(
+ PropertiesUtil.extractSubset(rootProperties,
"monitorResources"));
+ for (final Map.Entry<String, Properties> entry :
monitorResources.entrySet()) {
+ builder.add(createMonitorResource(entry.getKey().trim(),
entry.getValue()));
+ }
Review Comment:
Yes, that is exactly the syntax I would suggest for the `*.properties`
format.
Your updated code handles it well, but please consider a more generic
approach I added in
https://github.com/apache/logging-log4j2/pull/3501#pullrequestreview-2865367633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
