MichaelMorrisEst commented on code in PR #3501:
URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2102184817


##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/properties/PropertiesConfigurationBuilder.java:
##########
@@ -124,6 +125,12 @@ public PropertiesConfiguration build() {
             }
         }
 
+        final Map<String, Properties> monitorResources = 
PropertiesUtil.partitionOnCommonPrefixes(
+                PropertiesUtil.extractSubset(rootProperties, 
"monitorResources"));
+        for (final Map.Entry<String, Properties> entry : 
monitorResources.entrySet()) {
+            builder.add(createMonitorResource(entry.getKey().trim(), 
entry.getValue()));
+        }

Review Comment:
   If I understand your comment correctly the configuration should then look 
like:
   
   ```
   monitorResources.type = MonitorResources
   monitorResources.0.type = MonitorResource
   monitorResources.0.uri = file://path/to/external-file-1.txt
   monitorResources.1.type = MonitorResource
   monitorResources.1.uri = file://path/to/external-file-2.txt
   ```
   I've update the code accordingly, let me know if this is not correct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to