vy commented on code in PR #3501:
URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2081647646
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java:
##########
@@ -323,10 +325,19 @@ public void start() {
LOGGER.info("Starting configuration {}...", this);
this.setStarting();
if (watchManager.getIntervalSeconds() >= 0) {
- LOGGER.info(
- "Start watching for changes to {} every {} seconds",
- getConfigurationSource(),
- watchManager.getIntervalSeconds());
+ if (uris != null && uris.size() > 0) {
+ LOGGER.info(
+ "Start watching for changes to {} and {} every {}
seconds",
+ getConfigurationSource(),
+ uris,
+ watchManager.getIntervalSeconds());
+ watchMonitorUris();
+ } else {
+ LOGGER.info(
+ "Start watching for changes to {} every {} seconds",
+ getConfigurationSource(),
+ watchManager.getIntervalSeconds());
+ }
Review Comment:
> The reason I did not put it in initializeWatchers() is because
initializeWatchers() is called before the elements are read.
> ...
> Would it be ok to move invoking watchMonitorUris() to intialization()
@MichaelMorrisEst, right, okay, let's do that.
I think you can also simplify the 1st argument in the `"Start watching for
changes to {} every {} seconds"` log line and receive it from
`watchManager.getConfigurationWatchers().keySet()`. Give that a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
