MichaelMorrisEst commented on code in PR #3501:
URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2054283402
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java:
##########
@@ -767,6 +785,18 @@ protected void doConfigure() {
setParents();
}
+ private List<URI> convertToJavaNetUris(final List<Uri> uris) {
+ final List<URI> javaNetUris = new ArrayList<>();
+ for (Uri uri : uris) {
+ try {
+ javaNetUris.add(new URI(uri.getUri()));
+ } catch (URISyntaxException e) {
+ LOGGER.error("Error parsing monitor URI: " + uri, e);
Review Comment:
My thinking here was to be consistent with other error scenarios, for
example lines 726, 764, 790.
Also to let the exception propagate we would need to declare it on the
doConfigure() method which could cause an impact on anyone with their own
custom implementation which extends AbstractConfiguration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
