garydgregory commented on code in PR #3467:
URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1959779457
##########
log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java:
##########
@@ -67,21 +67,23 @@ public MongoDb4Connection(
final ConnectionString connectionString,
final MongoClient mongoClient,
final MongoDatabase mongoDatabase,
+ final String collectionName,
Review Comment:
IMO, saying that everything (IOW public and protected) in all of Log4j is
bound by binary compatibility is not a good thing and a bit of a fantasy we've
not strictly adhered to in the past. The public API IMO is `log4j-api` and
that's what's binary compatible, always.
More than that are just handcuffs we're putting on ourselves. Log4j API call
sites can happily hum along from release to release. Third-party Implementors
(as few as there may be) of these APIs need to be aware of _all_ the changes
from release to release, where behavioral changes will be trickier to deal with
for them anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
