jesmith17 commented on code in PR #3467:
URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1958833167
##########
log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java:
##########
@@ -67,21 +67,23 @@ public MongoDb4Connection(
final ConnectionString connectionString,
final MongoClient mongoClient,
final MongoDatabase mongoDatabase,
+ final String collectionName,
Review Comment:
So there are 2 challenges here.
1. The build system that log4j uses is something that I have not been able
to get to work on my machine. Even if I solve odd errors like
distributionSha256Sum challenges and downgrade the java version, it still gets
blocked by issues with some of the docker steps due to ARM architecture of my
Mac, so running that command isn't currently possible.
2. I understand your point about the constructor, but the constructor is
only called from inside the build method. And with the builder pattern people
should be using the build method to handle all of those pieces anyway and not
directly invoking the constructor. This approach is inline with previously
requested changes in the `main` branch and moving these would just make the
change bigger and make it a larger difference between 2.x and the 3.x
approaches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
