JWT007 commented on code in PR #3372:
URL: https://github.com/apache/logging-log4j2/pull/3372#discussion_r1957397458
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java:
##########
@@ -945,11 +944,20 @@ public Filter getFilter() {
return filter;
}
+ /**
+ * @deprecated Use {@link #withFilter(Filter)} instead
+ */
+ @Deprecated
public B withtFilter(final Filter filter) {
this.filter = filter;
return asBuilder();
}
+ public B withFilter(final Filter filter) {
Review Comment:
@ppkarwasz
I changed the LoggerConfig.RootLogger.Builder#withFilter to #setFilter.
The change of LoggerConfig.Builder#withFilter was not part of my original
change, but I have now deprecated that too and added a 'setFilter' there as
well. I couldn't change the name of the existing #withFilter there without
triggering a major baseline change.
I updated the tests using the #createLoggerConfig. Fixed other code in same
test methods to use builders as well (i.e. FileAppender).
NOTE I did not update test 'JiraLog4j2_2134Test' since it seems to
*explicitly* be testing deprecated methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
