ppkarwasz commented on code in PR #3372:
URL: https://github.com/apache/logging-log4j2/pull/3372#discussion_r1957283823
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java:
##########
@@ -945,11 +944,20 @@ public Filter getFilter() {
return filter;
}
+ /**
+ * @deprecated Use {@link #withFilter(Filter)} instead
+ */
+ @Deprecated
public B withtFilter(final Filter filter) {
this.filter = filter;
return asBuilder();
}
+ public B withFilter(final Filter filter) {
Review Comment:
Since we settled on using "setters" for new builder methods instead of
"withers" (see e.g. #1206), could you change it to `setFilter`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
