tristantarrant commented on issue #3399: URL: https://github.com/apache/logging-log4j2/issues/3399#issuecomment-2625650992
Yes, I'll submit the pr tomorrow morning. Sorry, I was busy on other things On Thu, 30 Jan 2025, 21:17 Volkan Yazıcı, ***@***.***> wrote: > CHM uses locks too. For a lock-free design, we can implement a > copy-on-write in combination with a CAS loop on an AtomicReference, but > this design would have its own performance trade offs. I am inclined to > keep the current simple rw-lock design. I think your stress test choking > up > on w-lock contention doesn't reflect a real world use case to engineer > further the concurrency of InternalLR. > > Tristan, doesn’t #3418, plus your one-liner fixes address your problem? I > thought you will submit a PR for that, right? > > Op do 30 jan 2025 om 16:34 schreef Tristan Tarrant ***@***.*** > > > > > Maybe we should look for a lock-less solution. A ConcurrentHashMap with > > support for weak keys ? > > > > — > > Reply to this email directly, view it on GitHub > > < > https://github.com/apache/logging-log4j2/issues/3399#issuecomment-2624827965>, > > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AAARTSMMV4W4G5OML2POWSD2NJBAHAVCNFSM6AAAAABVILZIVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRUHAZDOOJWGU> > > > . > > You are receiving this because you were mentioned.Message ID: > > ***@***.***> > > > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/logging-log4j2/issues/3399#issuecomment-2625489404>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAC72HTX6CTU7GUY2PSE5AD2NKCGJAVCNFSM6AAAAABVILZIVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRVGQ4DSNBQGQ> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org