JWT007 commented on issue #3368: URL: https://github.com/apache/logging-log4j2/issues/3368#issuecomment-2576461840
Thanks @ppkarwasz , I don't know how many people are using Log4j via the Builders... For me, wither/setter doesn't matter to me as long as it works (personally I prefer withers in builders - its feels more "builder" than "bean" :P). But yeah from a purist perspective the configuration builders are currently all over the place - withers/setters, sometimes conversion (ie. String -> Level) must happen before calling builder, sometimes not - *some* filters have "createNewFilter" others use Builders.... I guess *I* wouldn't be as critical about binary compatibility between major releases - at least not on a non-public API (core) "edge-case" :). But I am (thankfully) not responsibile for a major logging library .D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
