vy commented on issue #3368: URL: https://github.com/apache/logging-log4j2/issues/3368#issuecomment-2573789575
I would expect there to be more compatibility implications. Nevertheless, these classes should never be accessed programmatically — that is how we advise users in docs too. Hence, I am fine with making appender builders final and removing their type param. Op ma 6 jan 2025 om 16:12 schreef Piotr P. Karwasz ***@***.*** > > From a coding perspective a trivial change but more of a binary > compatibility problem. > > Removing the type variable B should be binary compatible (the erasure of B > is Builder, so the descriptor of the methods remains the same). The only > problem would be adding the final modifier to the Builder class (and > removing the public constructor). > > It is probably OK to do that. @vy <https://github.com/vy>, what do you > think? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/logging-log4j2/issues/3368#issuecomment-2573315201>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAARTSLAK2VIURAKM3LTJY32JKMPBAVCNFSM6AAAAABUVWVDLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZTGMYTKMRQGE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
