ppkarwasz commented on code in PR #3338:
URL: https://github.com/apache/logging-log4j2/pull/3338#discussion_r1898974783


##########
log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/instant/InstantPatternDynamicFormatter.java:
##########
@@ -689,16 +466,16 @@ public int hashCode() {
 
         @Override
         public String toString() {
-            return String.format("<%s>%s", pattern, precision);
+            return getClass().getSimpleName() + "[" + "pattern='" + pattern + 
'\'' + ", precision=" + precision + ']';

Review Comment:
   The shorter version is ambiguous, since both the `DTFPatternSequence` and 
`SecondPatternSequence` can have the same precision and pattern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to